Add listNamespaces GraphQL query with namespace git config#1928
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Mar 26, 2026
Merged
Add listNamespaces GraphQL query with namespace git config#1928shangyian merged 2 commits intoDataJunction:mainfrom
listNamespaces GraphQL query with namespace git config#1928shangyian merged 2 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
listNamespaces GraphQL query with namespace git config
642fd4f to
c2f61a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Namespaces were not queryable via GraphQL at all, and the UI had no reliable way to identify git root namespaces (it was checking deployment source badges rather than actual git configuration).
This PR adds a
listNamespacesGraphQL query that returns each namespace with agit: NamespaceGitunion field, which is eitherGitRootConfig(repo,path,defaultBranch) for git root namespaces, orGitBranchConfig(branch,gitOnly,parentNamespace,root) for branch namespaces, or null for non-git namespaces.The resolver resolves branch configs inline by embedding the root config, so no extra round-trips are needed. The resolution logic in
get_git_info_for_namespaceis extracted into a syncresolve_git_info_from_maphelper to allow future batch/DataLoader usage.On the UI side, the namespace sidebar now fetches via listNamespacesWithGit (replacing two separate REST calls) and shows a Git badge on namespaces where there is a git root set.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan